Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] GlobScanOperator #1550

Merged
merged 6 commits into from
Oct 31, 2023
Merged

[FEAT] GlobScanOperator #1550

merged 6 commits into from
Oct 31, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Oct 30, 2023

Initial implementation of the GlobScanOperator that leverages our Rust globbing implementation

Closes: #1531

@github-actions github-actions bot added the enhancement New feature or request label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1550 (8f68e9c) into main (6bd8f51) will increase coverage by 0.00%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1550   +/-   ##
=======================================
  Coverage   85.20%   85.21%           
=======================================
  Files          54       54           
  Lines        5131     5120   -11     
=======================================
- Hits         4372     4363    -9     
+ Misses        759      757    -2     

see 4 files with indirect coverage changes

src/daft-scan/src/glob.rs Outdated Show resolved Hide resolved
@jaychia jaychia merged commit e6f2442 into main Oct 31, 2023
40 checks passed
@jaychia jaychia deleted the jay/glob-scan-operator branch October 31, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build a GlobScanOperator
1 participant